fix: fix one-page example rendering #1337
Conversation
|
|
@kangju2000 is attempting to deploy a commit to the formidable-labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looks good and tried locally. Thanks!
@carbonrobot you want to merge this or me?
|
@kangju2000 -- index a4e2c28..d6d7b0f 100644
--- a/examples/one-page/scripts/one-page.js
+++ b/examples/one-page/scripts/one-page.js
@@ -40,8 +40,8 @@ const USE_LOCAL = false;
// Import Map
// ================================================================================================
const importUrl = (k, v, extra = '') => {
- // Pin react.
- if (k === 'react') {
+ // Pin react and react-dom
+ if (k === 'react' || k === 'react-dom') {
v = reactVersion;
}
|
|
@ryan-roemer |
Description
Resolve issue where the one-page example does not render.
The version of react-dom was set to
>=18.0.0, causing a conflict between the latest version18.3.1and react18.2.0. This is resolved by locking react-dom to version18.2.0.👇 Screenshot when entering one-page
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
pnpm run check:ciand all checks pass